-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Replaced_unified_repr with repr #20982 #22928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixing repr issue
|
Assigning reviewers. If you would like to opt out of this review, comment R: @yeandy for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Can you please give more context on this change? |
|
Reminder, please take a look at this pr: @yeandy |
Tried method overriding but didn't do it properly, also new to open source so I don't know what happens next |
|
Thanks for the info, and contributing to Beam! In general, you're doing the right steps. You did The next steps would to address any PreCommit checks that are failing. You have a few We have a bot to automatically assign reviewers. (This time, it was me). You can also manually choose a reviewer if you know someone in particular you want to review. However, @AnandInguva and I are actually working on a bunch of changes (#22995) in preparation to support Python 3.10. While working, I had identified the need to address the issue (#20982) that you originally took, and made a PR (AnandInguva#4) already. I guess we accidentally started working on this at the same time 😅 I'd say you're welcome to continue work on this PR (and also take inspiration from what I've done). Depending on how fast/slow our 3.10 work takes (I can update you via this PR), you may be able to make this fix into master before us? But I also don't want there to be redundant work being done. @AnandInguva How do you think we should approach this? |
|
Both of you, Thanks for working on this. This is a blocker for Python 3.10 and it would be better if we could do it sooner than later. Andy has started some work and I think is about to be done with it. |
|
Thank you for guiding @yeandy @AnandInguva , I guess I'll leave this issue to you both and try contributing to some other issue |
|
Also is there any way to see whether the checks are failing before creating a pr? |


fixing repr issue
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.