Skip to content

Conversation

@alive2020
Copy link

@alive2020 alive2020 commented Aug 28, 2022

Please add a meaningful description for your change here
#2888

  • According to ticket Beam-2888: Created a completely new Capability Matrix that is based on the ValidatesRunner tests:
  • Currently, the implementation includes: getting parsed JSON data from gcloud and rendering a small and big Capability Matrix table

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@alive2020
Copy link
Author

@pabloem

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor

Abacn commented Aug 28, 2022

Thanks for the contribution. Could you please set .gitignore in your local "nodes_modules"? Those are JavaScript libraries and should not be contained in the Beam repository. Could consider providing a script to setup environment (not familiar with npm here but other people could help).

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2022

Reminder, please take a look at this pr: @Abacn

@pabloem
Copy link
Member

pabloem commented Sep 6, 2022

ah I can review this btw. @alive2020 please do address @Abacn comment to remove nodes_modlues

@alive2020 alive2020 changed the title Docs/beam start GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888 Sep 9, 2022
.gitignore Outdated

# Node
sdks/typescript/node_modules
node_modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node_modules
node_modules/**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this then run git rm --cached -r node_modules and commit the change. This will remove node_modules files from the branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Removed.

@Abacn
Copy link
Contributor

Abacn commented Sep 9, 2022

@alive2020 Please DO NOT put service account key into this public repo. They have been disabled once leaked.

This commit: 7c7338d

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@Abacn
Copy link
Contributor

Abacn commented Sep 23, 2022

Will do

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left some more comments about the organization.

color-pb: "d8d8d8"
color-n: "e1e0e0"
color-nb: "bcbcbc"
color-y: 'fff'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason changing " -> '? They look redundant

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it's due to my vscode setup.


# Node
sdks/typescript/node_modules
node_modules/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still multiple website dependency files in the repo root directory e.g. package-locks.json, package.json, yarn.lock. Should organize it in somewhere under website folder.

There is already a project root in "website/www/" , there is an yarn.lock and package.json file there for the website dependency. (and website/www/node_modules is already in .gitignore)

Or If it is necessary to create a different project to generete the capability matrix, could move them into website/generate_capability_matrix project or so.

May ask @pabloem which one of the choice is preferred.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants