-
Notifications
You must be signed in to change notification settings - Fork 4.5k
GSoC-2022 latest_capability_matrix based on ValidatesRunner tests beam-2888 #22930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d work on uploading file to google cloud
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks for the contribution. Could you please set |
|
Reminder, please take a look at this pr: @Abacn |
|
ah I can review this btw. @alive2020 please do address @Abacn comment to remove nodes_modlues |
.gitignore
Outdated
|
|
||
| # Node | ||
| sdks/typescript/node_modules | ||
| node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| node_modules | |
| node_modules/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this then run git rm --cached -r node_modules and commit the change. This will remove node_modules files from the branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Removed.
|
@alive2020 Please DO NOT put service account key into this public repo. They have been disabled once leaked. This commit: 7c7338d |
|
Reminder, please take a look at this pr: @Abacn |
|
Will do |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Left some more comments about the organization.
| color-pb: "d8d8d8" | ||
| color-n: "e1e0e0" | ||
| color-nb: "bcbcbc" | ||
| color-y: 'fff' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason changing " -> '? They look redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it's due to my vscode setup.
|
|
||
| # Node | ||
| sdks/typescript/node_modules | ||
| node_modules/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still multiple website dependency files in the repo root directory e.g. package-locks.json, package.json, yarn.lock. Should organize it in somewhere under website folder.
There is already a project root in "website/www/" , there is an yarn.lock and package.json file there for the website dependency. (and website/www/node_modules is already in .gitignore)
Or If it is necessary to create a different project to generete the capability matrix, could move them into website/generate_capability_matrix project or so.
May ask @pabloem which one of the choice is preferred.
|
Reminder, please take a look at this pr: @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
|
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Please add a meaningful description for your change here
#2888
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.