Skip to content

Make WindowMappingFn#maximumLookback Configurable but Final#2307

Closed
tgroh wants to merge 1 commit intoapache:masterfrom
tgroh:window_mapping_fun_params
Closed

Make WindowMappingFn#maximumLookback Configurable but Final#2307
tgroh wants to merge 1 commit intoapache:masterfrom
tgroh:window_mapping_fun_params

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented Mar 23, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

This enforces that it return a constant value.

This enforces that it return a constant value.
@tgroh
Copy link
Member Author

tgroh commented Mar 23, 2017

R: @bjchambers

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d9092c9 on tgroh:window_mapping_fun_params into ** on apache:master**.

@asfbot
Copy link

asfbot commented Mar 23, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8741/
--none--

Copy link
Contributor

@bjchambers bjchambers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a test or something that ensures that the return value never exceeds the maximum lookback?

@tgroh
Copy link
Member Author

tgroh commented Mar 27, 2017

That should likely be a checkState or similar within the runner; it doesn't seem meaningfully possible to assert that via test.

@asfgit asfgit closed this in 1ea3b35 Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments