Skip to content

Fix caching in the Spark streaming, doing the cache update in the str… #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbonofre wants to merge 2 commits into from
Closed

Fix caching in the Spark streaming, doing the cache update in the str… #2314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6411c9
Fix caching in the Spark streaming, doing the cache update in the str…
jbonofre Mar 24, 2017
d25d73b
Fix order of call
jbonofre Mar 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import org.apache.beam.runners.spark.translation.TransformTranslator;
import org.apache.beam.runners.spark.translation.streaming.Checkpoint.CheckpointDir;
import org.apache.beam.runners.spark.translation.streaming.SparkRunnerStreamingContextFactory;
import org.apache.beam.runners.spark.translation.streaming.StreamingTransformTranslator;
import org.apache.beam.runners.spark.util.GlobalWatermarkHolder.WatermarksListener;
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.io.Read;
Expand Down Expand Up @@ -163,11 +162,6 @@ public SparkPipelineResult run(final Pipeline pipeline) {
JavaStreamingContext.getOrCreate(checkpointDir.getSparkCheckpointDir().toString(),
contextFactory);

// update cache candidates
translator = new StreamingTransformTranslator.Translator(
new TransformTranslator.Translator());
updateCacheCandidates(pipeline, translator, contextFactory.getEvaluationContext());

// Checkpoint aggregator/metrics values
jssc.addStreamingListener(
new JavaStreamingListenerWrapper(
Expand Down Expand Up @@ -269,7 +263,7 @@ private void detectTranslationMode(Pipeline pipeline) {
/**
* Evaluator that update/populate the cache candidates.
*/
private void updateCacheCandidates(
public static void updateCacheCandidates(
Pipeline pipeline,
SparkPipelineTranslator translator,
EvaluationContext evaluationContext) {
Expand Down
6 changes: 2 additions & 4 deletions ...g/apache/beam/runners/spark/translation/streaming/SparkRunnerStreamingContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ public JavaStreamingContext create() {
SparkRunner.initAccumulators(options, jsc);

ctxt = new EvaluationContext(jsc, pipeline, jssc);
// update cache candidates
SparkRunner.updateCacheCandidates(pipeline, translator, ctxt);
pipeline.traverseTopologically(new SparkRunner.Evaluator(translator, ctxt));
ctxt.computeOutputs();

Expand All @@ -91,10 +93,6 @@ public JavaStreamingContext create() {
return jssc;
}

public EvaluationContext getEvaluationContext() {
return this.ctxt;
}

private void checkpoint(JavaStreamingContext jssc) {
Path rootCheckpointPath = checkpointDir.getRootCheckpointDir();
Path sparkCheckpointPath = checkpointDir.getSparkCheckpointDir();
Expand Down