Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 10, 2022

Fixes #23178

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Sep 10, 2022
@Abacn Abacn marked this pull request as ready for review September 10, 2022 16:38
@Abacn
Copy link
Contributor Author

Abacn commented Sep 10, 2022

Run Java PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Sep 10, 2022

R: @tvalentyn
R: @lostluck

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn marked this pull request as draft September 10, 2022 17:11
@Abacn
Copy link
Contributor Author

Abacn commented Sep 10, 2022

Still working

@Abacn Abacn force-pushed the datetimefix branch 8 times, most recently from 178afe2 to 9116e0e Compare September 12, 2022 00:53
* Specify correct coder for  millis_instant

* [DO NOT MERGE] test only
@lostluck
Copy link
Contributor

Run Java Precommit

@Abacn Abacn changed the title Fix ZetaSQL cannot find coder of datetime logical type [DO NOT MERGE] Fix ZetaSQL cannot find coder of datetime logical type Sep 12, 2022
@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2022

@lostluck Sorry just ignore the PR. The first approach did not work out and this PR becomes debug only.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2022

Closes as found the cause is that container image needs an update rather than that suspected here

@Abacn Abacn closed this Sep 12, 2022
@Abacn Abacn deleted the datetimefix branch September 12, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression: ZetaSQL cannot find coder for row that contains datetime type on Runner V2

2 participants