GA Migration PostCommit Beam Metrics Publish #23323
Conversation
|
Tests were successful on the latest runner (2.296.2). Nonetheless, I’d recommend holding off on the migration of this particular workflow since the version of the runner needed (2.296.2) breaks functionality for other workflows. |
| uses: actions/checkout@v3 | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive |
There was a problem hiding this comment.
Do we really need to check out the submodules here? I imagine for most of these workflows we don't. The only places we should need them are when we're using one of the actions listed here (https://github.com/apache/beam/blob/master/.gitmodules) which I don't think we do in any of the migrated workflows, or when updating the website (where it may or may not be necessary)
.test-infra/metrics/build.gradle
Outdated
| beamgrafana=gcr.io/apache-beam-testing/beamgrafana:${project.lastCommitId} \ | ||
| beammetricssyncjenkins=gcr.io/apache-beam-testing/beammetricssyncjenkins:${project.lastCommitId} \ | ||
| beammetricssyncgithub=gcr.io/apache-beam-testing/beammetricssyncgithub:${project.lastCommitId}" | ||
| beamgrafana-test=gcr.io/apache-beam-testing/beamgrafana-test:${project.lastCommitId} \ |
There was a problem hiding this comment.
Why are we retargeting these?
There was a problem hiding this comment.
Oh I need to change this one to the correct values.
For testing purposes we targeted it to another instance.
Thanks for the heads up!
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
2 participants
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
Migrated workflow job-postcommit-beam-metrics-publish.yml
The migrated workflow was removed from .test-infra/jenkins/README.md and added to CI.md
DO NOT MERGE until the effort to use self-hosted runners is completed #22703
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.