Separate View Evaluation and Overrides#2347
Closed
tgroh wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
Author
|
R: @jkff |
|
Refer to this link for build results (access rights to CI server needed): |
tgroh
force-pushed
the
view_as_not_pvalue
branch
from
1b97b35 to
953d6cf
Compare
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 1.11 MB...] at hudson.remoting.UserRequest.perform(UserRequest.java:153) at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoFailureException: You have 2 Checkstyle violations. at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute(CheckstyleViolationCheckMojo.java:588) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-31T01:13:13.197 [ERROR] 2017-03-31T01:13:13.197 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-31T01:13:13.197 [ERROR] 2017-03-31T01:13:13.197 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-31T01:13:13.197 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-03-31T01:13:13.198 [ERROR] 2017-03-31T01:13:13.198 [ERROR] After correcting the problems, you can resume the build with the command2017-03-31T01:13:13.198 [ERROR] mvn -rf :beam-runners-direct-javachannel stoppedSetting status of 953d6cf to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8986/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
jkff
requested changes
Mar 31, 2017
| PCollection<Integer> ints = p.apply("CreateContents", Create.of(1, 2, 3)); | ||
| final PCollectionView<List<Integer>> view = | ||
| PCollectionViews.listView(p, WindowingStrategy.globalDefault(), ints.getCoder()); | ||
| PCollectionView<List<Integer>> afterReplacement = |
Contributor
There was a problem hiding this comment.
This variable is unused; are you sure this test is testing the code you changed?
Member
Author
There was a problem hiding this comment.
Yes, but I've made this more explicit. The application is the important part; we're creating a view manually to get around the View.asFoo transforms.
| @Override | ||
| public void visitPrimitiveTransform(Node node) { | ||
| assertThat( | ||
| "WriteView should be the last primtitive in the graph", |
Contributor
There was a problem hiding this comment.
- typo: primitive
- why?
- this condition is actually testing that there's exactly one WriteView transform, not that it's "last"
Member
Author
There was a problem hiding this comment.
- Fixed
- Updated to assert that we only write the view once, and it has the output we expect.
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 870.18 KB...] at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1029) at org.apache.maven.plugin.compiler.TestCompilerMojo.execute(TestCompilerMojo.java:170) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-31T18:21:25.075 [ERROR] 2017-03-31T18:21:25.075 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-31T18:21:25.075 [ERROR] 2017-03-31T18:21:25.075 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-31T18:21:25.075 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-03-31T18:21:25.076 [ERROR] 2017-03-31T18:21:25.076 [ERROR] After correcting the problems, you can resume the build with the command2017-03-31T18:21:25.076 [ERROR] mvn -rf :beam-runners-direct-javachannel stoppedSetting status of 2e7ea7f to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9010/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 870.48 KB...] at hudson.remoting.UserRequest.perform(UserRequest.java:50) at hudson.remoting.Request$2.run(Request.java:336) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.compiler.CompilationFailureException: Compilation failure at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1029) at org.apache.maven.plugin.compiler.TestCompilerMojo.execute(TestCompilerMojo.java:170) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 more2017-03-31T18:38:24.967 [ERROR] 2017-03-31T18:38:24.967 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-31T18:38:24.967 [ERROR] 2017-03-31T18:38:24.967 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-31T18:38:24.967 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException2017-03-31T18:38:24.967 [ERROR] 2017-03-31T18:38:24.967 [ERROR] After correcting the problems, you can resume the build with the command2017-03-31T18:38:24.967 [ERROR] mvn -rf :beam-runners-direct-javachannel stoppedSetting status of 3a51c7f to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9011/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install--none-- |
This simplifies the View Evaluation by separating it from the logic of overriding CreatePCollectionView.
tgroh
force-pushed
the
view_as_not_pvalue
branch
from
3a51c7f to
dd0f9f5
Compare
|
Refer to this link for build results (access rights to CI server needed): |
jkff
approved these changes
Mar 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This simplifies the View Evaluation by separating it from the logic of
overriding CreatePCollectionView.