Skip to content

Comments

[BEAM-1425] Window should comply with PTransform style guide#2362

Closed
jkff wants to merge 5 commits intoapache:masterfrom
jkff:window-style
Closed

[BEAM-1425] Window should comply with PTransform style guide#2362
jkff wants to merge 5 commits intoapache:masterfrom
jkff:window-style

Conversation

@jkff
Copy link
Contributor

@jkff jkff commented Mar 29, 2017

Incompatible changes:

  • Window.Bound class is now simply Window: matters for users that were extracting the transform into a variable.
  • Static methods such as Window.triggering(), Window.withAllowedLateness() etc. are now available via Window.configure() - e.g. Window.configure().withAllowedLateness(...). The method Window.into() is left intact as it is the primary entry point for windowing a collection, whereas the other methods are for adjusting the parameters of the windowing function.

R: @tgroh

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0ec3afc on jkff:window-style into ** on apache:master**.

@asfbot
Copy link

asfbot commented Mar 29, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8924/
--none--

@jkff
Copy link
Contributor Author

jkff commented Mar 31, 2017

Ping.

Copy link
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 132d3c5 Mar 31, 2017
@jkff jkff deleted the window-style branch March 31, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants