Skip to content

Comments

[BEAM-1795] Upgrade google-cloud-bigquery to 0.23.0#2378

Closed
markflyhigh wants to merge 2 commits intoapache:masterfrom
markflyhigh:update-bigquery-version
Closed

[BEAM-1795] Upgrade google-cloud-bigquery to 0.23.0#2378
markflyhigh wants to merge 2 commits intoapache:masterfrom
markflyhigh:update-bigquery-version

Conversation

@markflyhigh
Copy link
Contributor

@markflyhigh markflyhigh commented Mar 30, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Update google-cloud-bigquery to next stable version. No additional dependency is introduced after transitive dependency inspection.

'googledatastore==7.0.0',
# GCP packages required by tests
'google-cloud-bigquery>=0.22.1,<0.23',
'google-cloud-bigquery>=0.23.0,<1.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the upper bound to 0.24.0. With major version 0 it is possible to introduce breaking changes with minor version changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see. will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aaltay
Copy link
Member

aaltay commented Mar 30, 2017

LGTM

@asfgit asfgit closed this in d4de137 Mar 30, 2017
@asfbot
Copy link

asfbot commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8971/

Build result: FAILURE

[...truncated 2.11 MB...] at java.lang.Thread.run(Thread.java:745)Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed. at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:302) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134) at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208) ... 31 moreCaused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404) at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:764) at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:711) at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:289) ... 33 more2017-03-30T23:15:33.508 [ERROR] 2017-03-30T23:15:33.508 [ERROR] Re-run Maven using the -X switch to enable full debug logging.2017-03-30T23:15:33.508 [ERROR] 2017-03-30T23:15:33.508 [ERROR] For more information about the errors and possible solutions, please read the following articles:2017-03-30T23:15:33.508 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException2017-03-30T23:15:33.508 [ERROR] 2017-03-30T23:15:33.508 [ERROR] After correcting the problems, you can resume the build with the command2017-03-30T23:15:33.508 [ERROR] mvn -rf :beam-sdks-pythonchannel stoppedSetting status of 051b163 to FAILURE with url https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8971/ and message: 'Build finished. 'Using context: Jenkins: Maven clean install
--none--

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 61c0347 on markflyhigh:update-bigquery-version into ** on apache:master**.

@asfbot
Copy link

asfbot commented Mar 30, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/8972/
--none--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants