Skip to content

Improve PTransformMatcher ToStrings #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tgroh wants to merge 1 commit into from
Closed

Improve PTransformMatcher ToStrings #2386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...tion-java/src/main/java/org/apache/beam/runners/core/construction/PTransformMatchers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.beam.runners.core.construction;

import com.google.common.base.MoreObjects;
import java.util.HashSet;
import java.util.Set;
import org.apache.beam.sdk.annotations.Experimental;
Expand Down Expand Up @@ -67,6 +68,13 @@ private EqualClassPTransformMatcher(Class<? extends PTransform> clazz) {
public boolean matches(AppliedPTransform<?, ?, ?> application) {
return application.getTransform().getClass().equals(clazz);
}

@Override
public String toString() {
return MoreObjects.toStringHelper(EqualClassPTransformMatcher.class)
.add("class", clazz)
.toString();
}
}

/**
Expand All @@ -85,6 +93,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return false;
}

@Override
public String toString() {
return MoreObjects.toStringHelper("SplittableParDoSingleMatcher").toString();
}
};
}

Expand All @@ -105,6 +118,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return false;
}

@Override
public String toString() {
return MoreObjects.toStringHelper("StateOrTimerParDoSingleMatcher").toString();
}
};
}

Expand All @@ -124,6 +142,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return false;
}

@Override
public String toString() {
return MoreObjects.toStringHelper("SplittableParDoMultiMatcher").toString();
}
};
}

Expand All @@ -144,6 +167,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return false;
}

@Override
public String toString() {
return MoreObjects.toStringHelper("StateOrTimerParDoMultiMatcher").toString();
}
};
}

Expand All @@ -165,6 +193,13 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return fnType.equals(fn.getClass());
}

@Override
public String toString() {
return MoreObjects.toStringHelper("ParDoWithFnTypeMatcher")
.add("fnType", fnType)
.toString();
}
};
}

Expand All @@ -179,6 +214,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
return (application.getTransform() instanceof Flatten.PCollections)
&& application.getInputs().isEmpty();
}

@Override
public String toString() {
return MoreObjects.toStringHelper("EmptyFlattenMatcher").toString();
}
};
}

Expand All @@ -201,6 +241,11 @@ public boolean matches(AppliedPTransform<?, ?, ?> application) {
}
return false;
}

@Override
public String toString() {
return MoreObjects.toStringHelper("FlattenWithDuplicateInputsMatcher").toString();
}
};
}

Expand Down