[BEAM-1873] Fix Javadoc in BigQueryIO.java#2418
[BEAM-1873] Fix Javadoc in BigQueryIO.java#2418reuvenlax wants to merge 3 commits intoapache:masterfrom
Conversation
reuvenlax
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
| * {@link BigQueryIO.Write#withFormatFunction} to convert each element into a {@link TableRow} | ||
| * object. | ||
| * | ||
| * <p>Per-value tables are not yet supported in batch mode. |
There was a problem hiding this comment.
Please clarify: does this mean that per-value tables will use BigQuery streaming insert API, or does it mean that BigQueryIO inspects the "streaming" PipelineOption and refuses to work if it's false? (it'd be much better if it was the former)
There was a problem hiding this comment.
Right now it means the former (which actually works very poorly, and hence we say is unsupported). The other PR I submitted makes it work properly in batch using batch load jobs.
| @@ -152,13 +152,12 @@ private static void populateCommonDisplayData(DisplayData.Builder builder, | |||
| .withLabel("Pubsub Topic")); | |||
There was a problem hiding this comment.
Please remove this commit from the PR.
reuvenlax
force-pushed
the
fix_bq_javadoc
branch
from
246698f to
6657d0d
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
reuvenlax
force-pushed
the
fix_bq_javadoc
branch
from
1756a95 to
3b6a9b0
Compare
|
Refer to this link for build results (access rights to CI server needed): |
jkff
left a comment
jkff
left a comment
There was a problem hiding this comment.
Thanks, I'll squash, edit commit message and merge.
4 participants
Properly address new API for dynamic table writes.
R: @jkff