Skip to content

Conversation

@MakarkinSAkvelon
Copy link
Contributor

@MakarkinSAkvelon MakarkinSAkvelon commented Nov 16, 2022

resolves #22367
Playground does not use Example bucket anymore
Terraform code was changed
Readme file was changed


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

Copy link
Contributor

@olehborysevych olehborysevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (please check RAT)

@rshamunov rshamunov self-requested a review November 17, 2022 09:52
Copy link
Contributor

@rshamunov rshamunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MakarkinSAkvelon MakarkinSAkvelon marked this pull request as ready for review November 17, 2022 11:45
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloem LGTM I was able to provision the infrastructure successfully. However, I was still unable to fully test as the docker images didn't build as a result of ./gradlew playground:terraform:gkebackend -Pproject_environment="environment_name" -Pdocker-tag="tag" -Pdns-name="playground.zone". I will keep watching and testing for future fixes of our docker image build process.

@pabloem pabloem merged commit 9bad75f into apache:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Remove playground-precompiled-objects bucket from terraform scripts of Playground

5 participants