[BEAM-1881] Exclude protobuf-lite and replace with protobuf-java#2433
[BEAM-1881] Exclude protobuf-lite and replace with protobuf-java#2433dhalperi wants to merge 2 commits intoapache:masterfrom
Conversation
They are not compatible; protobuf-lite is only intended for use with Android.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): Failed Tests: 0--none-- |
|
retest this please |
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM pending the question about the grpc-protobuf-lite dependency.
| <dependency> | ||
| <groupId>org.apache.beam</groupId> | ||
| <artifactId>beam-sdks-java-core</artifactId> | ||
| <exclusions> |
| @@ -534,12 +534,12 @@ | |||
| <groupId>io.grpc</groupId> | |||
| <artifactId>grpc-protobuf-lite</artifactId> | |||
There was a problem hiding this comment.
Can this dependency be completely removed too?
There was a problem hiding this comment.
This is just setting the version for it via dependency management, but AFAICT no because the grpc-protobuf library depends on it. In practice, grpc-protofbuf depends on grpc-protobuf-lite but excludes the transitive protobuf-lite dependency.
| </requireMavenVersion> | ||
| <bannedDependencies> | ||
| <excludes> | ||
| <exclude>com.google.protobuf:protobuf-lite</exclude> |
|
Refer to this link for build results (access rights to CI server needed): |
4 participants
They are not compatible; protobuf-lite is only intended for use with Android.
R: @iemejia
Please take a look :)