-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[Playground] parse url_notebook example tag #24402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Playground] parse url_notebook example tag #24402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below is a long-lasting issue with updating big number of entities in a transaction
really complicates testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to keep path, to not break old backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking its removal? If not, could we add one?
playground/infrastructure/helper.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too much work for this PR(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above - could we add an issue for this (or drop a link in this comment if one already exists)?
playground/infrastructure/config.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the order of words to 'VCS URL' here and everywhere else. Also 'notebook URL'.
This is a better English, and also Robert Martin suggests the most important words at the end, and 'URL' is definitive among the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO these concerns are less important than
the fact that these fields are logically related and are better be alphabetically adjacent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no place we use could use it
playground/infrastructure/helper.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the refactoring is needed, but it would be too much for this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good opportunity to add trailing commas in this and other affected files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check the Python's habits for acronyms? In Dart and many other languages the habit is to capitalize only the first letter. For instance the class for URI is named Uri in Dart. I guess urlVcs would better in this case.
And also since we change to 'VCS URL' order this becomes vcsUrl and notebookUrl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this casing is already used in other Datastore fields in Playground
8d975ee to
77ad06f
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
77ad06f to
28ac4a1
Compare
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had some minor nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking its removal? If not, could we add one?
playground/infrastructure/helper.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above - could we add an issue for this (or drop a link in this comment if one already exists)?
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* github_url * get_vcs_path
resolves #24225
follow-up PR which uses new fields: #24425
example tag:
Resulting pg_examples entity has an old
pathfield along with new ones:urlVCS(==path) andurlNotebookProposed update sequence:
link,url_vcs, andurl_notebookto not break old frontend clienturl_vcsandurl_notebook, ignoreslinkOptional steps:
pathis removed from pg_examples, infrastructure merged, examples CD step appliedlinkfield removed from proto and marked reservedThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.