Skip to content

Conversation

@tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Dec 3, 2022

Parameter order appears incorrect, see:

producer_batch_converter, # type: Optional[BatchConverter]

self._get_runtime_performance_hints())

@github-actions github-actions bot added the python label Dec 3, 2022
@tvalentyn
Copy link
Contributor Author

Run Dataflow Python ValidatesRunner

@tvalentyn
Copy link
Contributor Author

Run Python Dataflow ValidatesRunner

@tvalentyn
Copy link
Contributor Author

R: @AnandInguva

@tvalentyn
Copy link
Contributor Author

cc: @robertwb fyi.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #24511 (68b3b33) into master (a76ab8a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24511      +/-   ##
==========================================
- Coverage   73.36%   73.36%   -0.01%     
==========================================
  Files         718      718              
  Lines       97186    97186              
==========================================
- Hits        71305    71302       -3     
- Misses      24533    24536       +3     
  Partials     1348     1348              
Flag Coverage Δ
python 82.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <ø> (-0.13%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 97.01% <0.00%> (-1.50%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.08% <0.00%> (-0.17%) ⬇️
sdks/python/apache_beam/runners/render.py 49.45% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn tvalentyn merged commit 8afa52f into apache:master Dec 4, 2022
@tvalentyn tvalentyn deleted the param_misalingment branch December 4, 2022 02:19
lostluck pushed a commit to lostluck/beam that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants