Skip to content

Comments

[BEAM-1832] Fix for potentially unclosed streams in ApexYarnLauncher#2454

Closed
rekhajoshm wants to merge 1 commit intoapache:masterfrom
rekhajoshm:BEAM-1832-0
Closed

[BEAM-1832] Fix for potentially unclosed streams in ApexYarnLauncher#2454
rekhajoshm wants to merge 1 commit intoapache:masterfrom
rekhajoshm:BEAM-1832-0

Conversation

@rekhajoshm
Copy link
Contributor

[BEAM-1832] Fix for potentially unclosed streams in ApexYarnLauncher

  • Using try-resources to handle closeable close issue
  • Removed redundant semicolons, string null assignment
  • Indent/spaces as per beam codestyle. Checkstyle passes. mvn clean verify passes.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.817% when pulling 46700c6 on rekhajoshm:BEAM-1832-0 into 37e4cc1 on apache:master.

@asfbot
Copy link

asfbot commented Apr 6, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9248/
--none--

@tweise
Copy link
Contributor

tweise commented Apr 8, 2017

@rekhajoshm I don't think it is desirable to reformat entire files to make relatively small changes. It looks like large chunks of code moved around without change. Can you please submit the first 2 items as separate PR that only contains those changes? Thanks!

@rekhajoshm rekhajoshm closed this Apr 8, 2017
@rekhajoshm rekhajoshm deleted the BEAM-1832-0 branch April 8, 2017 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants