Skip to content

[BEAM-1865]: Fix GroupByKeyInputVisitor for Direct Runner#2470

Closed
vikkyrk wants to merge 2 commits intoapache:masterfrom
vikkyrk:py_gbk_type_check
Closed

[BEAM-1865]: Fix GroupByKeyInputVisitor for Direct Runner#2470
vikkyrk wants to merge 2 commits intoapache:masterfrom
vikkyrk:py_gbk_type_check

Conversation

@vikkyrk
Copy link
Contributor

@vikkyrk vikkyrk commented Apr 8, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

  • Also handle None input types which is the case when TypeOptions.pipeline_type_check is disabled.

@vikkyrk
Copy link
Contributor Author

vikkyrk commented Apr 8, 2017

R: @aaltay @sb2nov

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 69.813% when pulling c7f1a44 on vikkyrk:py_gbk_type_check into 0c3dc00 on apache:master.

@asfbot
Copy link

asfbot commented Apr 8, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9315/
--none--

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 70.178% when pulling a0e5a07 on vikkyrk:py_gbk_type_check into 836e8e4 on apache:master.

@asfbot
Copy link

asfbot commented Apr 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9369/
--none--

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 70.172% when pulling a0e5a07 on vikkyrk:py_gbk_type_check into 836e8e4 on apache:master.

@asfbot
Copy link

asfbot commented Apr 10, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_MavenInstall/9370/
--none--

@asfgit asfgit closed this in 7fd9c65 Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants