HIFIO Cassandra tests were failing if run twice in a row without a clean#2499
Closed
ssisk wants to merge 1 commit intoapache:masterfrom
Closed
HIFIO Cassandra tests were failing if run twice in a row without a clean#2499ssisk wants to merge 1 commit intoapache:masterfrom
ssisk wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
The root cause here is that the embedded cassandra service is not entirely in-memory - it stores some files to disk (which get wiped out by mvn clean.) So the unit tests should clean up the cassandra instance when it destroys the instance in the @afterclass (as we do in other embedded tests), but in this case they don't. To verify that this works, I ran this command sequence: |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
The embedded cassandra tests work correctly the first time they are run after a mvn clean - on any test phase execution of the jdk1.8-tests directory after that (ie, any time you run this unit tests again), they will fail. Thus, this passes our "mvn clean verify" runs and is not breaking CI, but will likely break any devs running tests in this directory locally without clean-ing. (aka, me)
R @dhalperi
R @tgroh
...whoever gets to this first