Test all Known Coders to ensure they Serialize via URN#2517
Test all Known Coders to ensure they Serialize via URN#2517tgroh wants to merge 2 commits intoapache:masterfrom
Conversation
Fix Coders to not encode VarIntCoders as VarLongCoders, and VarLongCoders not as known coders. Ensure that all known coders are tested. Use getComponents rather than getCoderArguments for known coders.
|
R: @lukecwik |
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
Minor comments in test and then LGTM
| .build(); | ||
|
|
||
| @BeforeClass | ||
| public static void validateKnownCoders() { |
There was a problem hiding this comment.
Use the Enclosed test runner and have two static nested classes, one containing this test and one containing the parameterized test. This way validateKnownCoders will not be incorrectly reported as a test error vs a test failure.
See:
http://stackoverflow.com/questions/8758294/test-cases-in-inner-classes-with-junit
or AvroIOTransformTest.java as well
|
Done. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM |
4 participants
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
Fix Coders to not encode VarIntCoders as VarLongCoders, and
VarLongCoders not as known coders.
Ensure that all known coders are tested.
Use getComponents rather than getCoderArguments for known coders.