[BEAM-1978] Avoid repackaging bigtable classes in dataflow runner.#2541
Closed
rangadi wants to merge 1 commit into
Closed
[BEAM-1978] Avoid repackaging bigtable classes in dataflow runner.#2541rangadi wants to merge 1 commit into
rangadi wants to merge 1 commit into
Conversation
Contributor
Author
Contributor
|
LGTM |
Contributor
Author
|
An integration test that was failing earlier passes now. |
|
Refer to this link for build results (access rights to CI server needed): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataflow bundled jar does not need to repackage bigtable classes. This repackaging was probably never required in Apache Beam. This didn't affect before BEAM-1722 (PR #2503) since it was a test dependency. Now it is a compile time dependency.
This can mess up classes when a project depends both on google-platform IOs and dataflow runner.