Add retry logic to Python boot script. #25473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow runners to act more quickly on failures rather than wait for all workers to die before the exiting the container.
Codecov Report
@@ Coverage Diff @@
## master #25473 +/- ##
==========================================
- Coverage 72.96% 72.79% -0.17%
==========================================
Files 745 749 +4
Lines 99174 99543 +369
==========================================
+ Hits 72362 72465 +103
- Misses 25446 25712 +266
Partials 1366 1366
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
antonbobkov
approved these changes
Feb 15, 2023
sdks/python/container/boot.go
Outdated
| // DoFns throwing exceptions. | ||
| errorCount += 1 | ||
| if errorCount < 4 { | ||
| log.Printf("Python (worker %v) exited: %v", workerId, err) |
There was a problem hiding this comment.
perhaps add more information in the logs about retries/failures. Maybe something along the lines of "Python (worker %v) exited: %v, retrying process." and "Python (worker %v) exited: %v, out of retries: restarting SDK container."
Contributor
Author
|
PTAL |
antonbobkov
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow runners to act more quickly on failures rather than wait for all workers to die before the exiting the container.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.