Skip to content

Conversation

@damccorm
Copy link
Contributor

Tox has changed this name - https://tox.wiki/en/latest/config.html#allowlist_externals

This has been supported since 3.18.0 - https://tox.wiki/en/3.18.1/changelog.html#v3-18-0-2020-07-23 and is now fully removed in tox >=4. Without this change, some tooling doesn't work on the newest tox


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

Run PythonDocs PreCommit

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #25647 (ccdd32c) into master (fabd1f6) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25647      +/-   ##
==========================================
+ Coverage   72.79%   72.82%   +0.02%     
==========================================
  Files         775      775              
  Lines      102863   102928      +65     
==========================================
+ Hits        74877    74953      +76     
+ Misses      26532    26522      -10     
+ Partials     1454     1453       -1     
Flag Coverage Δ
python 81.95% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/io/textio.py 94.59% <0.00%> (-2.47%) ⬇️
sdks/python/apache_beam/utils/interactive_utils.py 95.12% <0.00%> (-2.44%) ⬇️
sdks/python/apache_beam/io/fileio.py 96.12% <0.00%> (+0.04%) ⬆️
...python/apache_beam/runners/worker/worker_status.py 75.33% <0.00%> (+0.66%) ⬆️
sdks/python/apache_beam/io/localfilesystem.py 91.72% <0.00%> (+0.75%) ⬆️
...o/pkg/beam/runners/prism/internal/worker/worker.go 64.59% <0.00%> (+1.94%) ⬆️
sdks/python/apache_beam/dataframe/io.py 92.55% <0.00%> (+3.48%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm damccorm marked this pull request as ready for review February 27, 2023 22:31
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit d7d6a7f into apache:master Feb 28, 2023
@damccorm damccorm deleted the users/damccorm/allowist branch February 28, 2023 17:54
ruslan-ikhsan pushed a commit to akvelon/beam that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants