[BEAM-2000] run pylint on specific module

[ubunatic]

• added module option: any given args to the script will be used as the module for pep8 and pylint
• cleaned up bash syntax: removed square brackets, using more explicit test command instead

[aaltay]

R: @sb2nov

[coveralls]

Coverage remained the same at 70.669% when pulling 8a3f9a7 on ubunatic:run-pylint-module-option into 8f4bb01 on apache:master.

[sb2nov]

Thanks, looks good apart from the two nits.

[sb2nov]

Nit: Indent the then & else inside the if

[ubunatic]

OK.
However, I think the non-indented then and else is more readable in bash in this case, i.e., you should write either:

if ...
then single command
else single command
fi

or for multiple commands:

if ...; then
   indented commands
   more commands
else
   indented command
   more commands
fi

[sb2nov]

Nit: Indent the then & else inside the if

[ubunatic]

Done

[sb2nov]

LGTM, thanks for this 👍

@aaltay please merge

[aaltay]

Could you add a comment to the top of the file on how to use this (something like ./run_pylint.sh [module], module defaults apache_beam)

[coveralls]

Coverage decreased (-0.2%) to 70.456% when pulling a98fe93 on ubunatic:run-pylint-module-option into 8f4bb01 on apache:master.

[ubunatic]

OK I added the usage info.

Other question:
Did I miss any steps to make the CI checks succeed?
If they fail for most/all PRs, shouldn't we probably disable or fix them first?

[coveralls]

Coverage decreased (-0.003%) to 70.131% when pulling 926eb08 on ubunatic:run-pylint-module-option into 8319369 on apache:master.

[aaltay]

LGTM.

Travis tests are being currently removed. Although Travis tests give valid signals for Python development they are taking too long and timing out for Java tests. Part of the reason they are still there is Python on Mac tests are useful. (@jasonkuster may have more details)

Jenkins tests should not fail. If they do for an unrelated reason (like in this case) please file an issue for a flaky/failing tests.

[ubunatic]

Thx for the info. The Jenkins test failed because of the following flaky test https://issues.apache.org/jira/browse/BEAM-1868

[sb2nov]

Retest this please

[coveralls]

Coverage decreased (-0.006%) to 70.128% when pulling 926eb08 on ubunatic:run-pylint-module-option into 8319369 on apache:master.