Skip to content

Fix OutputSampler's coder#25805

Merged
pabloem merged 1 commit intoapache:masterfrom
rohdesamuel:data-sampling-java
Mar 14, 2023
Merged

Fix OutputSampler's coder#25805
pabloem merged 1 commit intoapache:masterfrom
rohdesamuel:data-sampling-java

Conversation

@rohdesamuel
Copy link
Copy Markdown
Contributor

@rohdesamuel rohdesamuel commented Mar 11, 2023

Previously, the OutputSampler coder would always be the Value coder (from a windowed value). This would cause a mismatch between the encoding for the PCollection defined in the ProcessBundleDescriptor vs. what is being given to the OutputSampler. The fix is to always sample WindowedValues and give the OutputSampler the literal rehydrated coder.

Task #25064


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Mar 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@rohdesamuel
Copy link
Copy Markdown
Contributor Author

R: @pabloem

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@pabloem
Copy link
Copy Markdown
Member

pabloem commented Mar 14, 2023

lgtm!

@pabloem pabloem merged commit 04c2de6 into apache:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants