Skip to content

Conversation

@robertwb
Copy link
Contributor

No need for these extra wrappers now.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R: @damondouglas

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #25916 (c637363) into master (fcf51fb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25916      +/-   ##
==========================================
+ Coverage   71.40%   71.42%   +0.01%     
==========================================
  Files         778      778              
  Lines      102430   102452      +22     
==========================================
+ Hits        73144    73175      +31     
+ Misses      27830    27821       -9     
  Partials     1456     1456              
Flag Coverage Δ
python 79.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_provider.py 62.79% <ø> (-0.68%) ⬇️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb
Copy link
Contributor Author

apache_beam.io.gcp.bigquery_test.PipelineBasedStreamingInsertTest.test_batch_size_with_auto_sharding_0 looks irrelevant.

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertwb LGTM I'm assuming the failing checks have nothing to do with this code.

@robertwb
Copy link
Contributor Author

Run Python PreCommit

@robertwb
Copy link
Contributor Author

Turns out the errors are related--windows uses backslashes for paths which are interpreted as escapes in the yaml. Blech. Pushed a fix.

@robertwb robertwb merged commit d80f1ff into apache:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants