Skip to content

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 7, 2023

mitigate #26175

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@Abacn
Copy link
Contributor Author

Abacn commented Apr 7, 2023

I now believe this is somewhat red herring. Direct runner simply is not efficient:

cron run 473: actual number of records 35990 smaller than expected: 100000.
cron run 475: actual number of records 26030 smaller than expected: 100000.
cron run 478: actual number of records 42390 smaller than expected: 100000.
cron run 479: actual number of records 39350 smaller than expected: 100000.
cron run 481: actual number of records 23190 smaller than expected: 100000.

with this change: actual number of records 51990 smaller than expected: 100000. <-- this is most likely due to running after hour and Jenkins is less loaded

Defer the connections into startBundle seems help a little bit so I intend to preserve the change, but also decrease the number of record and see.

The problem happens in read not related to recent code change.

@Abacn Abacn force-pushed the fixjmsioit branch 3 times, most recently from 951e332 to fcc6bc4 Compare April 8, 2023 00:41
@Abacn
Copy link
Contributor Author

Abacn commented Apr 9, 2023

Run Java_Jms_IO_Direct PreCommit

@Abacn
Copy link
Contributor Author

Abacn commented Apr 10, 2023

Jenkins seems unstable again

@Abacn Abacn closed this Apr 10, 2023
@Abacn Abacn reopened this Apr 10, 2023
@Abacn Abacn changed the title Defer connect to jms in startBundle Disable JmsIOIT on amqp Apr 10, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Apr 10, 2023

Jenkins not triggering. Ran spotlessApply locally. Test succeeded locally:

Package	Tests	Failures	Ignored	Duration	Success rate
org.apache.beam.sdk.io.jms	1	0	0	31.978s	100%

@Abacn Abacn marked this pull request as ready for review April 10, 2023 14:29
@Abacn
Copy link
Contributor Author

Abacn commented Apr 10, 2023

R: @jrmccluskey

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Apr 10, 2023

GitHub Action test passed but Jenkins not triggering. Merging this for now anyway as it is only scoped in JmsIOIT, and validated locally (both spotlessApply and integrationTest tasks)

@Abacn Abacn merged commit 7405cf3 into apache:master Apr 10, 2023
@Abacn Abacn deleted the fixjmsioit branch April 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants