Skip to content

Conversation

@mutianf
Copy link
Contributor

@mutianf mutianf commented Apr 10, 2023

fix #26166

In #24015, the map that stores BigtableService is transient. During serialized and deserialized, it recreates an empty map which ended up creating a new BigtableService per each thread. The fix makes the map static.

In the previous version, mutateRows operation has a timeout of 6 minutes. And after the migration, the default timeout became 1 minute, which makes the job fail more easily. Update the timeout back to 6 minutes.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @ahmedabu98 for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor

Run Java_GCP_IO_Direct PreCommit

1 similar comment
@Abacn
Copy link
Contributor

Abacn commented Apr 10, 2023

Run Java_GCP_IO_Direct PreCommit

@jrmccluskey
Copy link
Contributor

It looks like there's a somewhat consistent timeout in testTriggeredFileLoadsWithTempTablesToExistingNullSchemaTable:

17:37:22 org.apache.beam.sdk.io.gcp.bigquery.BigQueryIOWriteTest > testTriggeredFileLoadsWithTempTablesToExistingNullSchemaTable[1] FAILED
17:37:22     org.junit.runners.model.TestTimedOutException at BigQueryIOWriteTest.java:729
17:45:55 
17:45:55 1645 tests completed, 1 failed, 124 skipped

Is this a matter of needing higher bounds on the direct runner?

@Abacn
Copy link
Contributor

Abacn commented Apr 11, 2023

@jrmccluskey This is known issue #25207. It was causing the whole GCP_IO test suite time out before I added test timeout of 10min per test. From the log the suspected cause is some racing condition that temp file gets deleted when the test run and then test hanging. It happens occassionally but recently becomes more frequent. Possibly because other tests get added to GCP_IO then the order that junit running these test changed.

@jrmccluskey
Copy link
Contributor

retest this please

@jrmccluskey
Copy link
Contributor

Run Java_Examples_Dataflow_Java17 PreCommit

@jrmccluskey
Copy link
Contributor

Run Java_GCP_IO_Direct PreCommit

@jrmccluskey
Copy link
Contributor

Hmm still getting that Spanner IO failure. I don't have reason to believe it's related to this PR though. CC: @johnjcasey

@Abacn
Copy link
Contributor

Abacn commented Apr 11, 2023

Hmm still getting that Spanner IO failure. I don't have reason to believe it's related to this PR though. CC: @johnjcasey

That is #26208 unrelated to Beam

@jrmccluskey
Copy link
Contributor

Ah noted. In that case I'm comfortable merging this, the Java 11 examples passed but the PR didn't get updated

@jrmccluskey jrmccluskey merged commit 66c030b into apache:master Apr 11, 2023
mutianf added a commit to mutianf/beam that referenced this pull request Apr 11, 2023
…ase default attempt timeout (apache#26205)

* fix: fix BigtableServiceFactory to share BigtableService

* update timeout

* address comments, fix test
jrmccluskey pushed a commit that referenced this pull request Apr 11, 2023
…ase default attempt timeout (#26205) (#26223)

* fix: fix BigtableServiceFactory to share BigtableService

* update timeout

* address comments, fix test
@mutianf mutianf deleted the fix branch December 10, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in BigtableIO in the new 2.47.0 versions

4 participants