-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: Fix BigtableIO to share one BigtableService per worker and increase default attempt timeout #26205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...oud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfigTranslator.java
Show resolved
Hide resolved
...cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceFactory.java
Show resolved
Hide resolved
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Run Java_GCP_IO_Direct PreCommit |
1 similar comment
|
Run Java_GCP_IO_Direct PreCommit |
|
It looks like there's a somewhat consistent timeout in Is this a matter of needing higher bounds on the direct runner? |
|
@jrmccluskey This is known issue #25207. It was causing the whole GCP_IO test suite time out before I added test timeout of 10min per test. From the log the suspected cause is some racing condition that temp file gets deleted when the test run and then test hanging. It happens occassionally but recently becomes more frequent. Possibly because other tests get added to GCP_IO then the order that junit running these test changed. |
|
retest this please |
|
Run Java_Examples_Dataflow_Java17 PreCommit |
|
Run Java_GCP_IO_Direct PreCommit |
|
Hmm still getting that Spanner IO failure. I don't have reason to believe it's related to this PR though. CC: @johnjcasey |
That is #26208 unrelated to Beam |
|
Ah noted. In that case I'm comfortable merging this, the Java 11 examples passed but the PR didn't get updated |
…ase default attempt timeout (apache#26205) * fix: fix BigtableServiceFactory to share BigtableService * update timeout * address comments, fix test
fix #26166
In #24015, the map that stores BigtableService is transient. During serialized and deserialized, it recreates an empty map which ended up creating a new BigtableService per each thread. The fix makes the map static.
In the previous version, mutateRows operation has a timeout of 6 minutes. And after the migration, the default timeout became 1 minute, which makes the job fail more easily. Update the timeout back to 6 minutes.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.