Skip to content

Conversation

@damccorm
Copy link
Contributor

Right now, our stalebot doesn't process all issues/pull requests. This is because by default, the stale action has a limit of 30 operations per run to avoid rate limiting. Since reading a batch of 100 issues/PRs is considered a single operation, we aren't able to fully make it through the backlog of issues/PRs (which is >4000). This applies even though we are only acting on PRs because GitHub can't effectively tell the difference between the 2.

Upping our limit to 100 will ensure that all pull requests will be processed. Since we only run this once per hour, this shouldn't really impact our rate limit of 1,000 operations per hour for the whole repo's GitHub Actions. We're not utilizing a significant portion of this elsewhere.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@damccorm
Copy link
Contributor Author

damccorm commented Apr 12, 2023

R: @liferoad @Abacn

@github-actions github-actions bot added the build label Apr 12, 2023
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading a batch of 100 issues/PRs is considered a single operation

Does this mean with the change the number of operation by the workflow is not expected to increase?

@damccorm
Copy link
Contributor Author

Does this mean with the change the number of operation by the workflow is not expected to increase?

No, it will still go up because we need to read ~4,000 issues and ~200 PRs (so at least (4000 + 200)/100=42 operations), plus we will still need to perform write operations (adding labels and closing PRs) sometimes.

@damccorm damccorm merged commit 9f8c9bb into master Apr 12, 2023
@damccorm damccorm deleted the users/damccorm/stale branch April 12, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants