Add Pubsub lite write metrics and DLQ support #26482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
nickuncaged1201
force-pushed
the
pubsub-lite-metrics
branch
from
a05bb56 to
063add5
Compare
Contributor
|
Spotless seems to be failing, can you fix that. LGTM otherwise |
Contributor
Author
|
r: @johnjcasey |
nickuncaged1201
force-pushed
the
pubsub-lite-metrics
branch
from
2cf07b0 to
6bb708f
Compare
bvolpato
approved these changes
May 3, 2023
Contributor
|
Run Java_GCP_IO_Direct PreCommit |
Contributor
|
|
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* init * fixup * no data being processed. debugging * added element counter * only error counter and dlq. Removed element counter * add unit test * change name * resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error metrics and dlq routing support for pubsub lite write schema transform. Tested the DoFn functionality with unit test.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.