Skip to content

Conversation

@riteshghorse
Copy link
Contributor

This PR adds support for passing any additional arguments for loading models with custom config for TensorFlow models.
https://www.tensorflow.org/tutorials/keras/save_and_load


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@riteshghorse riteshghorse marked this pull request as ready for review May 4, 2023 14:46
@github-actions github-actions bot added the python label May 4, 2023
@riteshghorse
Copy link
Contributor Author

R: @damccorm

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #26548 (544e3a6) into master (a13749f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 544e3a6 differs from pull request most recent head c879997. Consider uploading reports for the commit c879997 to get more accurate results

@@           Coverage Diff           @@
##           master   #26548   +/-   ##
=======================================
  Coverage   81.11%   81.12%           
=======================================
  Files         469      469           
  Lines       67438    67498   +60     
=======================================
+ Hits        54705    54756   +51     
- Misses      12733    12742    +9     
Flag Coverage Δ
python 81.12% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/apache_beam/ml/inference/tensorflow_inference.py 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Contributor Author

Failing tests are not related to the changes in this PR.
Merging!

@riteshghorse riteshghorse merged commit d7c6d60 into apache:master May 5, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
* add load model args option, unit tests

* update doc comment for new args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants