Support configuration of maxCapacityPerShard when reading from Kinesis with EFO #26666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
R: @psolomin |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
psolomin
reviewed
May 11, 2023
Contributor
psolomin
left a comment
psolomin
left a comment
There was a problem hiding this comment.
Thanks 👍 looks good overall.
I left a couple of small suggestions.
...ava/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java
Outdated
Show resolved
Hide resolved
...web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/EFOShardSubscribersPool.java
Outdated
Show resolved
Hide resolved
…s with EFO (closes apache#26257)
mosche
force-pushed
the
26257_KinesisIO_EFO_maxCapacityPerShard
branch
from
26e3a9f to
252c6fd
Compare
Member
Author
|
Thanks @psolomin, good catch! I've addressed your comments. |
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…s with EFO (closes apache#26257) (apache#26666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuration of maxCapacityPerShard when reading from Kinesis with EFO
(closes #26257)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.