Conversation
|
Could you add a JIRA issue to upgrade to 0.5.9 and as a warning for what is wrong. |
f5be041 to
9cdcde4
Compare
|
R: @aaltay done. |
|
Should we actually pin all dependencies? We make the assumption that our dependencies would not introduce breaking changes without a major version change but it happens frequently. |
|
I don't have strong opinions around this but here are some of my thoughts:
|
|
Your have valid points. Then at release time we need to ensure that corresponding pieces (e.q. dataflow container) has at least the minimum version of all referenced dependencies. |
|
LGTM |
|
Thanks |
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
R: @aaltay PTAL