Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed. #26777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @robertwb |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
Run Python_Dataframes PreCommit |
…er to a clause that marks the bundle as failed.
tvalentyn
force-pushed
the
sdk_report_all_errors
branch
from
2e7cd4c to
ca2a267
Compare
Codecov Report
@@ Coverage Diff @@
## master #26777 +/- ##
==========================================
- Coverage 72.05% 71.97% -0.08%
==========================================
Files 745 747 +2
Lines 101203 101306 +103
==========================================
- Hits 72920 72916 -4
- Misses 26824 26931 +107
Partials 1459 1459
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
…er to a clause that marks the bundle as failed. (apache#26777)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user code raises a BaseException during processing, bundle will be marked as failed by the SDK but will not be reported as failed to the worker harness. To fix this, match the error handling catch clause in the outer method to the error handling close where bundle is marked failed:
beam/sdks/python/apache_beam/runners/worker/sdk_worker.py
Line 683 in dbefe4f