Restore the behavior that failing to create a venv fails the pipeline. #26797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26797 +/- ##
=======================================
Coverage 71.97% 71.97%
=======================================
Files 747 747
Lines 101306 101306
=======================================
+ Hits 72914 72916 +2
+ Misses 26933 26931 -2
Partials 1459 1459
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
R: @lostluck |
Contributor
Author
|
tested both default and opt-out codepaths on Dataflow. |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Contributor
Author
|
R: @liferoad |
liferoad
approved these changes
May 20, 2023
Contributor
|
Failure not related to this PR, merging Thanks! |
riteshghorse
approved these changes
May 21, 2023
riteshghorse
approved these changes
May 21, 2023
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore prior behavior: when venv fails to install, fail the execution, but add actionable logs. See: #26792 for context.