[BEAM-2074,BEAM-2073] Fixed SourceDStream's rate control usage.#2733
Merged
asfgit merged 1 commit intoapache:masterfrom May 1, 2017
staslev:BEAM-2074-2073-fix-SourceDStream-rate-control
Merged
[BEAM-2074,BEAM-2073] Fixed SourceDStream's rate control usage.#2733asfgit merged 1 commit intoapache:masterfrom staslev:BEAM-2074-2073-fix-SourceDStream-rate-control
asfgit merged 1 commit intoapache:masterfrom
staslev:BEAM-2074-2073-fix-SourceDStream-rate-control
Conversation
Contributor
Author
|
Run Spark ValidatesRunner |
Contributor
Author
|
retest this please. |
Contributor
Author
|
Run Spark ValidatesRunner |
Contributor
Author
|
R: @aviemzur |
aviemzur
reviewed
Apr 30, 2017
| final scala.Option<Long> rateControlledMax = rateControlledMaxRecords(); | ||
| if (rateControlledMax.isDefined()) { | ||
| LOG.info("Max records per batch has been set to {}, as advised by the rate controller.", | ||
| rateControlledMax.get()); |
Member
There was a problem hiding this comment.
Could extract param as this is called twice. not crucial.
Contributor
Author
|
Prior to submitting this PR I briefly played around with trying to test it, but could not find an easy way to test things at the level of inspecting rates per individual batches and the likes. I believe this deserves a separate JIRA so please feel free to file one. |
4 tasks
Contributor
Author
|
Rebased against #2698. |
Contributor
Author
|
Run Spark ValidatesRunner |
Contributor
Author
|
Run Spark ValidatesRunner |
Contributor
Author
|
Run Spark ValidatesRunner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.