Skip to content

Conversation

@volatilemolotov
Copy link
Contributor

Adds a possibility to create new runner pools with matching node pools.
Update env file to accommodate new variables

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Jul 5, 2023
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, if you move it out of draft I will merge

@volatilemolotov volatilemolotov marked this pull request as ready for review July 6, 2023 15:41
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 9e6420d into apache:master Jul 6, 2023
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
* adds additional pools object

* adding disk size and removing old variables

* changed default labelset for additional pools

* updated beam.env

* formatting

* add gcloud login to readme and sync environment
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
* adds additional pools object

* adding disk size and removing old variables

* changed default labelset for additional pools

* updated beam.env

* formatting

* add gcloud login to readme and sync environment
@volatilemolotov volatilemolotov deleted the arc_additional_pools branch August 10, 2023 08:23
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
* adds additional pools object

* adding disk size and removing old variables

* changed default labelset for additional pools

* updated beam.env

* formatting

* add gcloud login to readme and sync environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants