-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Arc additional pools #27369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Arc additional pools #27369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6988aa to
063c2e1
Compare
damccorm
approved these changes
Jul 6, 2023
Contributor
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, if you move it out of draft I will merge
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 10, 2023
* adds additional pools object * adding disk size and removing old variables * changed default labelset for additional pools * updated beam.env * formatting * add gcloud login to readme and sync environment
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 17, 2023
* adds additional pools object * adding disk size and removing old variables * changed default labelset for additional pools * updated beam.env * formatting * add gcloud login to readme and sync environment
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* adds additional pools object * adding disk size and removing old variables * changed default labelset for additional pools * updated beam.env * formatting * add gcloud login to readme and sync environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a possibility to create new runner pools with matching node pools.
Update env file to accommodate new variables
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.