Add branch protection rules via .asf.yaml #27502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
R: @jrmccluskey |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 17, 2023
* Add branch protection rules via .asf.yaml * Fix branch replacement
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* Add branch protection rules via .asf.yaml * Fix branch replacement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the same level of branch protection we have currently, but does it through the .asf.yaml. This will make our disaster recovery story much cleaner since we will be able to enable force pushes as needed if we ever need to rewrite history.
Running the workflow against my repo produced this commit - feac140
Fixes #26721
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.