Skip to content

Conversation

@jon-esperanza
Copy link
Contributor

@jon-esperanza jon-esperanza commented Jul 22, 2023

Addresses #19561
After #24773, it was discovered that there needs to be an improvement to the unit tests for Row.equals to test edge cases on null values


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the java label Jul 22, 2023
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Abacn Abacn merged commit 30c324a into apache:master Jul 22, 2023
@jon-esperanza
Copy link
Contributor Author

jon-esperanza commented Jul 22, 2023

@Abacn
beam_PreCommit_Java_Examples_Dataflow check was failing, is there a reason why that might be?

@jon-esperanza jon-esperanza deleted the BEAM-19561 branch July 23, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants