Skip to content

Conversation

@zbynek
Copy link
Contributor

@zbynek zbynek commented Aug 6, 2023

New version of the JavaCC plugin is out: release notes. Because the plugin ID changed, it won't be found by usual dependency update mechanisms, so I'm making PRs manually to update all the major projects on GitHub that are using an older version of the plugin.

The new version should make compilation of the parser a bit faster and improve compatibility with future releases of Gradle.

I locally checked that ./gradlew compileJava is successful with this change, but have not done any other testing.

I don't think the change is impactful enough to require an entry in CHANGES.MD, please let me know if you disagree.

GitHub Actions Tests Status (on master branch)

https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #27869 (f66943c) into master (7754ab9) will increase coverage by 0.07%.
Report is 109 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27869      +/-   ##
==========================================
+ Coverage   70.88%   70.96%   +0.07%     
==========================================
  Files         861      861              
  Lines      105001   105055      +54     
==========================================
+ Hits        74433    74555     +122     
+ Misses      29007    28939      -68     
  Partials     1561     1561              
Flag Coverage Δ
python 79.95% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damccorm for label build.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @damccorm @Abacn

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will merge once merge conflicts are resolved and CI runs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just did away with owners files which is leading to this conflict, would you mind updating to pull in the changes from latest master?

@damccorm
Copy link
Contributor

Run Go PreCommit

@damccorm
Copy link
Contributor

Run Spotless PreCommit

@damccorm
Copy link
Contributor

(^please ignore, my comments are to trigger CI reruns that were flaky)

@damccorm damccorm merged commit be3428f into apache:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants