-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Update JavaCC Gradle plugin to latest version (3.0.0) #27869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27869 +/- ##
==========================================
+ Coverage 70.88% 70.96% +0.07%
==========================================
Files 861 861
Lines 105001 105055 +54
==========================================
+ Hits 74433 74555 +122
+ Misses 29007 28939 -68
Partials 1561 1561
Flags with carried forward coverage won't be shown. Click here to find out more. see 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I will merge once merge conflicts are resolved and CI runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just did away with owners files which is leading to this conflict, would you mind updating to pull in the changes from latest master?
|
Run Go PreCommit |
|
Run Spotless PreCommit |
|
(^please ignore, my comments are to trigger CI reruns that were flaky) |
New version of the JavaCC plugin is out: release notes. Because the plugin ID changed, it won't be found by usual dependency update mechanisms, so I'm making PRs manually to update all the major projects on GitHub that are using an older version of the plugin.
The new version should make compilation of the parser a bit faster and improve compatibility with future releases of Gradle.
I locally checked that
./gradlew compileJavais successful with this change, but have not done any other testing.I don't think the change is impactful enough to require an entry in CHANGES.MD, please let me know if you disagree.
GitHub Actions Tests Status (on master branch)
https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md




See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.