Skip to content

Better error messages on missing or malformed yaml providers.#28311

Merged
robertwb merged 2 commits intoapache:masterfrom
robertwb:yaml-misc
Sep 6, 2023
Merged

Better error messages on missing or malformed yaml providers.#28311
robertwb merged 2 commits intoapache:masterfrom
robertwb:yaml-misc

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Sep 5, 2023


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the python label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #28311 (c869e4b) into master (f91bb68) will increase coverage by 0.06%.
Report is 46 commits behind head on master.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master   #28311      +/-   ##
==========================================
+ Coverage   72.29%   72.36%   +0.06%     
==========================================
  Files         678      679       +1     
  Lines       99911   100210     +299     
==========================================
+ Hits        72233    72514     +281     
- Misses      26112    26130      +18     
  Partials     1566     1566              
Flag Coverage Δ
python 82.90% <87.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/yaml/yaml_provider.py 69.89% <71.42%> (-0.07%) ⬇️
sdks/python/apache_beam/yaml/yaml_transform.py 90.08% <100.00%> (+0.15%) ⬆️

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@robertwb
Copy link
Contributor Author

robertwb commented Sep 5, 2023

Run Python_Integration PreCommit

Copy link
Contributor

@AnandInguva AnandInguva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertwb robertwb merged commit 741e8c6 into apache:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants