Skip to content

Conversation

@jrmccluskey
Copy link
Contributor

The minimum Python version currently supported is 3.8, but there was some leftover logic in the Python boot.go script around wheel naming for versions 3.6 and 3.7. This change removes that unused logic.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #28414 (fcbfb08) into master (8b2525b) will increase coverage by 0.00%.
Report is 62 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #28414    +/-   ##
========================================
  Coverage   72.33%   72.33%            
========================================
  Files         681      682     +1     
  Lines      100355   100541   +186     
========================================
+ Hits        72592    72728   +136     
- Misses      26189    26239    +50     
  Partials     1574     1574            
Flag Coverage Δ
python 82.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jrmccluskey jrmccluskey merged commit 16f2e17 into apache:master Sep 12, 2023
@jrmccluskey jrmccluskey deleted the bootScoot branch September 12, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants