Disable Javascript UDFs for 2.51.0 #28542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Contributor
Author
|
R: @robertwb |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
robertwb
reviewed
Sep 19, 2023
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
Will this not cause several test failures?
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Codecov Report
@@ Coverage Diff @@
## master #28542 +/- ##
=======================================
Coverage 72.24% 72.24%
=======================================
Files 684 684
Lines 100946 100978 +32
=======================================
+ Hits 72924 72951 +27
- Misses 26443 26448 +5
Partials 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
@Polber should we close this since it didn't go in for 2.51? |
Contributor
|
Yeah, this was superseded by #29130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.