Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 23, 2023

To include the dependency updates in 1885251330.

The tag of the new container image is beam-master-20231023.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once checks pass

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #29109 (6ab1840) into master (a07d90e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #29109   +/-   ##
=======================================
  Coverage   38.37%   38.37%           
=======================================
  Files         686      686           
  Lines      101685   101685           
=======================================
  Hits        39017    39017           
  Misses      61088    61088           
  Partials     1580     1580           
Flag Coverage Δ
python 29.98% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hon/apache_beam/runners/dataflow/internal/names.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 42586c4 into apache:master Oct 23, 2023
Abacn pushed a commit to Abacn/beam that referenced this pull request Oct 23, 2023
Abacn added a commit that referenced this pull request Oct 23, 2023
#28516)

Co-authored-by: Shunping Huang <133698626+shunping-google@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants