Skip to content

Conversation

@pdewilde
Copy link

@pdewilde pdewilde commented Nov 10, 2023

addresses #29382

Exposes options from the underlying go BigQuery sdk to the bigqueryio package, to allow for Parameters, DefaultProjectId and DefaultDatasetID.

This allows for queries that are not susceptible to SQL injection attacks. Most values can be replaced via parameters, but parameters cannot be used for identifiers. DefaultProjectId and DefaultDatasetID help by allowing unqualified table names to be used in the query, reducing the need for string interpolation on queries where table names are known ahead of time and tables share datasets.

@pdewilde
Copy link
Author

fixes: #29382

@pdewilde
Copy link
Author

There seem to be very few existing tests in this package. I'll do some manual testing, though there is no significant logic to unit test (just that the added struct fields are copied over).

I would appreciate any feedback!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 9, 2024
@github-actions
Copy link
Contributor

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant