-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add logging in data plane code when processing is stuck waiting on data for an instruction. #29399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
5d01350 to
cdbe280
Compare
|
Run Python_PVR_Flink PreCommit |
|
Run Python_Coverage PreCommit |
|
Run PythonDocker PreCommit |
|
cc: @robertwb |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29399 +/- ##
==========================================
- Coverage 38.34% 38.33% -0.01%
==========================================
Files 693 694 +1
Lines 102199 102265 +66
==========================================
+ Hits 39185 39204 +19
- Misses 61422 61469 +47
Partials 1592 1592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 'Waiting to receive elements in input queue ' | ||
| 'for instruction: %s for %.2f seconds.', | ||
| instruction_id, | ||
| current_time - start_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add log_interval_sec in the log and mention this frequency?
Was this tested with Dataflow jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add log_interval_sec in the log and mention this frequency?
done
jrmccluskey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but +1 to @liferoad's question asking if this had been tested yet

Log when elements for an instruction are missing in data plane more than 5 minutes. This can help surface processing inefficiency between an SDK and a runner.