-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Improve File IO Logging #29485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve File IO Logging #29485
Conversation
|
R: @AnandInguva (since I saw you recently updated Python File IO). Feel free to reassign if preferred. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29485 +/- ##
==========================================
- Coverage 38.38% 37.82% -0.56%
==========================================
Files 687 686 -1
Lines 101745 100987 -758
==========================================
- Hits 39051 38196 -855
- Misses 61113 61210 +97
Partials 1581 1581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Abacn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
|
The actual error should be emitted from the gcs delete operation. Currently it does not (just return an error code): beam/sdks/python/apache_beam/io/gcp/gcsio.py Line 234 in 32b1067
The GCS migration work long struggled in proper handling errors in batch operation. CC: @shunping |
# Conflicts: # sdks/python/apache_beam/io/fileio.py
* Create HealthcareUtils file with shared resources * revert * improve logging * improve logging * better error msg * improve logging
When granting IAM permissions to
roles/storage.objectUser(or higher) on Google Cloud, the error in question does not surface. Adding a line on IAM permissions in logging, to better the error message.Note: can't share the code to prove this here since it's proprietary, but happy to demo on a call via sandbox.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.