Skip to content

Conversation

@shunping
Copy link
Collaborator

Reset protobuf version to 3.24.4 as an internal error is resolved.

This reverts commit 183141d.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Reset protobuf version to 3.24.4 as an internal error is
resolved.

This reverts commit 183141d.
@github-actions github-actions bot added the build label Nov 24, 2023
Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Shunping!

@codecov
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6e19eb) 37.86% compared to head (8fbc8ec) 37.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #29530   +/-   ##
=======================================
  Coverage   37.86%   37.86%           
=======================================
  Files         690      690           
  Lines      101352   101352           
=======================================
  Hits        38381    38381           
  Misses      61377    61377           
  Partials     1594     1594           
Flag Coverage Δ
python 29.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmedabu98 ahmedabu98 merged commit 5a63294 into apache:master Nov 24, 2023
@shunping shunping deleted the reapply-protobuf-3.24.4 branch November 24, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants