Skip to content

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented Dec 8, 2023


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

robertwb commented Dec 8, 2023

R: @Polber

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Polber Polber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking this PR, but I think it might be worth discussing a standardized format for representing the input and output schema of each transform

i.e. for ReadFromText having something like

schema:
  line: string

This of course is trickier for transforms like ReadFromBigQuery where the schema is dynamic, but having a format for static schemas is a good start.

@robertwb
Copy link
Contributor Author

Yeah, it'd be nice to be able to specify the expected output (and required input) PCollection schemas. I don't think that's available anywhere programatically. (I don't think it's fixed for many transforms, for better or for worse, but for those that it is it could be useful.)

@robertwb robertwb merged commit 192f765 into apache:master Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants