Skip to content

[BEAM-2184] Rename OutputTimeFn to TimestampCombiner.#2971

Closed
robertwb wants to merge 2 commits intoapache:masterfrom
robertwb:jira-2184
Closed

[BEAM-2184] Rename OutputTimeFn to TimestampCombiner.#2971
robertwb wants to merge 2 commits intoapache:masterfrom
robertwb:jira-2184

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented May 8, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@robertwb
Copy link
Contributor Author

robertwb commented May 8, 2017

R: @chamikaramj

@robertwb
Copy link
Contributor Author

robertwb commented May 9, 2017

R: @davorbonaci This was just a sed script.

@davorbonaci
Copy link
Member

LGTM; please self-merge & cherrypick

@chamikaramj
Copy link
Contributor

LGTM

@asfgit asfgit closed this in 844762d May 9, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 70.527% when pulling befcd46 on robertwb:jira-2184 into 152c5bc on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants