Skip to content

Actually run after-count tests.#2976

Closed
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:run-pipeline
Closed

Actually run after-count tests.#2976
robertwb wants to merge 1 commit intoapache:masterfrom
robertwb:run-pipeline

Conversation

@robertwb
Copy link
Contributor

@robertwb robertwb commented May 8, 2017

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify.
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@robertwb
Copy link
Contributor Author

robertwb commented May 8, 2017

R: @sb2nov

Copy link
Contributor

@sb2nov sb2nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from 1 question

'B-3': {10, 15, 16},
}.iteritems()))
with TestPipeline() as p:
p = TestPipeline()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need line L406 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, thanks for catching this.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 70.577% when pulling afa4f8a on robertwb:run-pipeline into 152c5bc on apache:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 70.58% when pulling afa4f8a on robertwb:run-pipeline into 152c5bc on apache:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants